Repository navigation
feat(vector): tag the Valkey Search client lib-name for attribution - #2620
Open
Jonathan-Improving wants to merge 1 commit into
Open
Jonathan-Improving wants to merge 1 commit into
Jonathan-Improving wants to merge 1 commit into
Conversation
Set client_info_tag='langbot' on the Valkey Search vector store's glide client, so CLIENT SETINFO LIB-NAME reports GlidePy(langbot) and operators can attribute Valkey usage to LangBot. client_name is unchanged. client_info_tag was added in valkey-glide 2.5.2, so raise the floor from >=2.4.1 to >=2.5.2 (pyproject, install hint, docs) and regenerate uv.lock.
Contributor
|
All contributors have signed the CLA. ✅ 所有贡献者均已签署 CLA。 |
Author
|
I have read the CLA Document and I hereby sign the CLA |
dadachann
added a commit
to langbot-app/cla
that referenced
this pull request
Sep 30, 2026
Author
|
The CLA assistant is still failing for some reason, despite I having signed the CLA. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述 / Overview
Follow-up to the Valkey Search vector backend (#2276). This sets a library-name tag on its glide client, so the server can tell LangBot's connections apart from any other valkey-glide user.
src/langbot/pkg/vector/vdbs/valkey_search.py—client_info_tag='langbot'on the oneGlideClientConfigurationin_ensure_client(). The existingclient_name='langbot_vector_client'stays as it is;CLIENT SETNAMEandCLIENT SETINFO LIB-NAMEare separate fields.pyproject.toml—valkey-glidefloor>=2.4.1,<3.0.0→>=2.5.2,<3.0.0, becauseclient_info_tagfirst shipped in 2.5.2. The install hint in theImportErroranddocs/VALKEY_SEARCH_INTEGRATION.mdare updated to match.uv.lock— regenerated withuv lock(valkey-glide 2.4.1 → 2.5.3, which brings intrio/sortedcontainers/outcomeas its own deps). uv 0.12.3 also simplified somenvidia-*/cuda-*resolution markers. I didn't hand-edit anything, and I'm happy to regenerate with whatever uv version you use.Metadata only: no behaviour change, and the Windows marker is untouched.
更改前后对比截图 / Screenshots
Observed on a live server (valkey 9.1.1, standalone), with the connection opened by
ValkeySearchVectorDatabaseitself:修改前 / Before:
lib-name=GlidePy(glide's untagged default, which doesn't distinguish LangBot)修改后 / After:
(
CLIENT LIST LIB-NAME 'GlidePy(langbot)'returns the connection. The backend only builds a standaloneGlideClient, so there is no cluster path to check.)检查清单 / Checklist
PR 作者完成 / For PR author
tests/unit_tests/vector: 116 passed; the single failure,TestQdrantFilterConversion::test_empty_filter_returns_empty_must, is unrelated to this change.ruff checkandruff format --checkare clean.)