Skip to content

fix: point glossary rows at live i18n keys - #1083

Merged
RiskeyL merged 3 commits into
mainfrom
fix/glossary-dead-keys
Oct 9, 2026
Merged

RiskeyL merged 3 commits into
mainfrom
fix/glossary-dead-keys

Conversation

@RiskeyL

@RiskeyL RiskeyL commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Points the glossary rows whose i18n keys no longer exist at their live keys, and takes each row's values from the new key. The termbase is regenerated from the glossary.

Re-keyed, label unchanged

  • Embed Into Site: deployments.studio.accessPoint.embedIntoSite (Access Point Web App card; the Agent card uses agent-v-2.agentDetail.access.webApp.actions.embedIntoSite)
  • Unpublished changes: agent-v-2.agentDetail.configure.publishBar.unpublishedChanges (Agent publish bar only)
  • Backend Service API: agent-v-2.agentDetail.access.serviceApi.title, the visible card title on Workflow, Chatflow and Agent apps. The old app-overview.overview.apiInfo.title is only the switch's accessible label. The duplicate row under Agent Configure is merged into this one.
  • Settings (Vision): app-debug.voice.settings, the key the button actually renders

Label changed to match the UI

  • Explore → Web apps (explore.sidebar.webApps; en Web apps, zh WEB APPS, ja Webアプリ), plus a new Home row (common.mainNav.home). Both arrived in 1.17.0.
  • My account → My Account (common.account.myAccount)
  • External API → External Knowledge API (dataset.externalAPIPanelTitle)

Knowledge Retrieval node and Text Generator

  • The node's labels get their own Knowledge Retrieval Node Config section. They sat under Agent Node Config before.
  • The node's "Query Variable" row is replaced by Query Text and Query Images (workflow.nodes.knowledgeRetrieval.queryText / .queryAttachment).
  • New rows for the metadata filtering modes Disabled, Automatic and Manual (workflow.nodes.knowledgeRetrieval.metadata.options.*.title). The ja values are 無効, 自動生成 and 手動設定.
  • Query variable (app-debug.feature.dataSet.queryVariable.title, ja クエリ変数) moves to Variable Config. It renders only in Text Generator once a knowledge base is attached.

Removed

  • Assistant: the existing Chatbot row covers the app type.
  • No changes, and Automatic as a document processing mode (dataset-creation.stepTwo.auto): neither label exists any more. The metadata filter's Automatic is a separate label, added above.
  • High-quality mode, Economy mode (Document Embedding Modes): dead keys duplicating the live High Quality and Economical rows.
  • Custom moves to dataset-documents.embedding.custom.

Added

  • Configure and Launch, for the Web App card's hidden-field pre-fill. The ja Launch label reads 公開.
  • Knowledge Base Access, All Knowledge Bases, Specific Knowledge Bases, for the Knowledge Service API key scope.

Rule

  • The UI Labels intro now says rows record the string stored at the key, even when the UI changes its case on screen (Web apps shows as WEB APPS).

Verification

  • Keys and values were verified at dify 1.17.1 (8387590ace). The same keys were spot-checked on dify main, where i18n moved to web/i18n/locales/ (the key checker can't read that layout yet).
  • tools/translate/check-glossary-keys.py --ref 8387590ace reports 6 dead keys out of 215, all Workspace Roles rows, which are left for the role-naming decision.
  • derive-termbase.py --check is in sync.
  • No docs prose uses the removed labels.

No backport: the glossary and termbase are shared writing resources. The Text Generator label fix ships separately so it can be backported on its own.

Refs DC-284

Copilot AI balanced review requested due to automatic review settings October 8, 2026 08:06
@mintlify

mintlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
dify-ce-cloud-docs 🟢 Ready View Preview Oct 8, 2026, 8:07 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A live Automatic label is removed, Knowledge Retrieval rows are miscategorized, and localized tutorial instructions remain stale.

3 open findings
What changed in this PR

Updates multilingual terminology to match Dify 1.17.1 UI labels and i18n keys.

Changes:

  • Re-keys renamed and relocated UI labels.
  • Adds navigation, access, and retrieval terminology.
  • Regenerates the translation termbase.
File Description
writing-guides/​glossary.md Updates multilingual UI terminology and i18n mappings.
tools/​translate/​termbase_i18n.md Regenerates translation terms from the glossary.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread writing-guides/glossary.md
Comment thread writing-guides/glossary.md Outdated
Comment thread writing-guides/glossary.md
Ill-donut
Ill-donut previously approved these changes Oct 8, 2026
Move Query Text, Query Images and Metadata Filtering out of Agent Node Config, and add the metadata filtering modes Disabled, Automatic and Manual. Regenerate the termbase.
Copilot AI balanced review requested due to automatic review settings October 8, 2026 12:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The updated labels match the pinned Dify i18n values, and the generated termbase is synchronized.

0 open findings

3 resolved since last review

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Ill-donut
Ill-donut previously approved these changes Oct 9, 2026
State in the glossary's UI Labels intro that rows record the string stored at the key, even when the UI changes its case on screen.
Copilot AI balanced review requested due to automatic review settings October 9, 2026 05:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The removed Explore label remains in all three localized tutorial pages and their shared screenshot.

0 open findings

🧠 Review effort: Balanced

@RiskeyL
RiskeyL merged commit 45d4e56 into main Oct 9, 2026
2 checks passed
@RiskeyL
RiskeyL deleted the fix/glossary-dead-keys branch October 9, 2026 05:33
RiskeyL added a commit that referenced this pull request Oct 12, 2026
Brings in #1083 and #1094. Resolves the glossary conflict with #1083 by keeping its moved rows and this branch's new Output Routes row, and regenerates the termbase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants