feat: add search/filter functionality with result navigation (#114)#311
Open
yvng-jie wants to merge 1 commit into
Open
feat: add search/filter functionality with result navigation (#114)#311yvng-jie wants to merge 1 commit into
yvng-jie wants to merge 1 commit into
Conversation
leezng
reviewed
Jul 21, 2026
leezng
left a comment
Owner
There was a problem hiding this comment.
Thanks. I have submitted a few ideas.
|
|
||
| // ── Search info bar ── | ||
| const showSearchBar = | ||
| props.showSearchResultInfo && props.searchText?.trim() && searchMatchInfo.totalCount > 0; |
Owner
There was a problem hiding this comment.
I think showSearchResultInfo should be implemented by the application layer. The component should only expose the foundational APIs; higher-level business logic doesn't belong in the component abstraction.
| | bracketsClick | triggers when click brackets | (collapsed: boolean, node: NodeData) | | ||
| | iconClick | triggers when click icon | (collapsed: boolean, node: NodeData) | | ||
| | selectedChange | triggers when the selected value changed | (newVal, oldVal) | | ||
| | searchMatchChange | triggers when search results change or navigation occurs | ({ currentIndex, totalCount }) | |
Owner
There was a problem hiding this comment.
I think it could be changed to search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the search/filter feature requested in #114.
Features
searchTextpropsearchModesupports'key','value', or'all'searchCaseSensitivepropsearchStrictprop for exact match modenextMatch()/prevMatch()methods exposed via ref, withsearchMatchChangeeventshowSearchResultInfoprop shows match count + ◀▶ buttons.vjs-highlightclass.is-active-matchvisual stylevirtualmodeNew Props
New Events
New Expose Methods