jws: jkuProvider rejects fetched keys marked use=enc - #2060
Merged
Merged
Conversation
Mirror the keySetProvider use-check inside jkuProvider.FetchKeys so a JWKS entry advertised for encryption (use="enc") is reported as a structured error naming the kid and the bad usage, rather than being passed through to AlgorithmsForKey and then failing as a generic "could not be verified" further down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
keySetProvideralready rejects JWKS entries markeduse="enc"with a structured error (signer-kiduse="enc" not usable for signature verification...). ThejkuProviderskipped that check, so ajku-resolved JWKS entry mismarked as a decryption key would fall through toAlgorithmsForKeyand surface as a generic "could not be verified with any of the keys".This mirrors the
selectKeycheck insidejkuProvider.FetchKeysimmediately after thekidlookup. Behavior change is limited to what was already a verification failure — operators just get a clearer error.v4 companion: #2059.