[v4] escape JSON object member names on output - #2348
Merged
Merged
Conversation
lestrrat
commented
Sep 8, 2026
Collaborator
- Fix GHSA-4cf7-xm37-g63h: a custom member name containing a double quote could add JSON members the caller never set.
- Escape names in the generator templates; names that need no escaping keep the allocation-free path.
- Ships through the normal release process; the advisory is published once v4.4.1 and v3.2.1 are tagged.
lestrrat
force-pushed
the
fix-v4-json-member-name-escaping
branch
from
September 8, 2026 03:26
d87e55b to
e90e24f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.