wip: TlsParametersV2 - #1087
Draft
paolobarbolini wants to merge 26 commits into
Draft
wip: TlsParametersV2#1087paolobarbolini wants to merge 26 commits into
TlsParametersV2#1087paolobarbolini wants to merge 26 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1081 I was reminded of the fact that
CertificateStoreis not marked#[non_exhaustive]. AlsoCertificateStore::Defaultis a bad option because it changes which certificate store it uses based on which features are enabled, which together with the fact that different TLS backend and different certificate stores support different features (for examplerustls-platform-verifierdoesn't supportdangerous_accept_invalid_hostnames, just like boring-tls doesn't).This makes me want to experiment having a different API that is better at dealing with these constraints.