Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep one upstream subscription per downstream producer and invoke callbacks through the existing native callback infrastructure. Algorithm reference: WICG Observable draft.
Validation from the repository root:
cargo fmt --allcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --no-fail-fastSummary [ 129.194s] 20823 tests run: 20823 passed (9 slow), 19 skipped (32 build jobs / test threads; automatic retries disabled).
Extracted from
wpt-misc-fixhistorical changes:61456bc260e4a3c9fcf2ad9713fa6f5afd736339.Stacked prerequisite: #1977.
Reentrancy note: callback indices advance after callback invocation, following the WICG draft. A nested notification sees the current index, and the implementation reads it again afterward to preserve nested increments. Chromium 145 differs on these reentrant cases.