fix: pin @slidev/cli to 52.15.2 to fix presenter view navigation#9
Merged
Conversation
Slidev 52.16.0 introduced a regression (slidevjs/slidev#2635, #2629) where getSlidePath double-applies BASE_URL: the router is already created with createWebHistory(BASE_URL), so navigation produced doubled paths (e.g. #/foss4g2026-talk/presenter/N that fail to match a route) on subdirectory deploys, breaking slide skipping in presenter view. Pinning to the last good release (52.15.2) restores base-less slide paths. Verified locally with a built --base /foss4g2026-talk/ deploy: presenter navigation now yields clean #/presenter/N URLs, no 404. Revert once the fix in slidevjs/slidev#2630 ships in a release. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSlidePath()to double-applyBASE_URL(Regression in 52.16.0 (#2562): getSlidePath double-prefixes BASE_URL → navigation 404 on subdirectory (--base) deploys slidevjs/slidev#2635, #2629), breaking slide navigation on subdirectory deploys — presenter view skipping produced doubled hash routes (e.g.#/foss4g2026-talk/presenter/N) that match no route.@slidev/clito the last good release 52.15.2, which returns base-less slide paths so the router applies the base exactly once.Test plan
--base /foss4g2026-talk/, serveddist, drove presenter navigation headlessly:#/presenter/4 → 5 → 6 → 5, no base doubling, no 404.Revert once slidevjs/slidev#2630 ships in a release.
Made with Cursor