fix: track emergency state separately for each side in ChessClock #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06be6c2 to
d503f0e
Compare
veloce
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1626.
This regression was introduced in #1135: The
_checkEmergency()function was copied from the oldCountdownClockwidget , for which there always was a separate instance per side. The newChessClockclass tracks the time of both sides, so we now also need to track theshouldPlayEmergencySound(which I renamed toshouldTriggerEmergencyCallback, as the class does not actually play sounds anymore since the refactoring) andnextEmergencyfields separately for each side.Added a regression tests as well.