Move lag compensation and clock improvements #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien4215
reviewed
Nov 14, 2024
| @@ -1,122 +1,99 @@ | |||
| import 'dart:async'; | |||
|
|
|||
| import 'package:clock/clock.dart'; | |||
There was a problem hiding this comment.
Why are we using this package for the countdown clock widget ?
I don't see why Datetime.now and the builtin Stopwatch would not work.
There was a problem hiding this comment.
To be able to test the clocks. Contrary to DateTime, clock is overridden in fakeAsync environment. So we can reliably measure the elapsed time in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the real time game clocks more precise by implementing:
A new chess clock for playable games with:
An update of
CountdownClockwidget:The latter is no more used for playable game, only for read-only display of clocks where live clock ticking is needed (TV, broadcast, etc).