Skip to content

Conversation

@sid0-0
Copy link

@sid0-0 sid0-0 commented Sep 16, 2024

PR implements: #992

Also includes minor cleanup

Screenshots:
image
image

@sid0-0
Copy link
Author

sid0-0 commented Sep 16, 2024

There are changes from 1 commit wherein I had to upgrade AGP version to make it work with flutter beta channel.
I can remove the commit but the question is, aren't these changes required?

@tom-anders
Copy link
Collaborator

tom-anders commented Sep 16, 2024

There are changes from 1 commit wherein I had to upgrade AGP version to make it work with flutter beta channel. I can remove the commit but the question is, aren't these changes required?

It's already fixed on the main branch, but your fork is a few commits behind.

One way to fix this:

git remote add upstream https://github.com/lichess-org/mobile.git
git pull upstream main --rebase
git push -f

You'll probably get a conflict with your first commit, just do git rebase --skip in that case

.userPrevious();

Future<void> _showAnalysisMenu(BuildContext context, WidgetRef ref) {
final analysisState = ref.read(analysisControllerProvider(pgn, options));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should read the state in the onPressed handler of the BottomSheetAction, not here.

@veloce veloce merged commit 28d6642 into lichess-org:main Sep 24, 2024
1 check passed
@veloce
Copy link
Contributor

veloce commented Sep 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants