Alternate castling was forced into normal castling #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the logic is correct, also Since the alternative castling notation is always tricky it would be good to also add a new test to the |
…ngs to normal castlings.
|
I also added the tests. It now works like on the lichess.org website. In the 3 pictures below, I played "e1g1", but it behaves as if I played "e1h1". So everything seems fine. It behaves the same as the Lichess.org website.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did something like this to solve this problem. If there was a castling move containing the values of the map here, I forced it to change it with its key. Before solving this problem, this needs to be solved first.
On the game analysis screen, I reduced eight castling alternatives to four. In all moves, there will be a movement just like the movement in the keys. Is this logic correct? If true, is this function the place of application?