Skip to content

Alternate castling was forced into normal castling #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Alternate castling was forced into normal castling #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
afe8936
alternative rock was forced into normal rock
okmsbun Feb 14, 2024
fe23acf
Alternate castling was forced into normal castling
okmsbun Feb 14, 2024
163f4d2
Merge branch 'lichess-org:main' into main
okmsbun Feb 20, 2024
e71ddd9
A unit test was written for the method that forces alternative castli…
okmsbun Feb 20, 2024
0357694
Merge branch 'lichess-org:main' into alternative_castling
okmsbun Feb 20, 2024
c64b251
Merge branch 'lichess-org:main' into alternative_castling
okmsbun Feb 20, 2024
ae9b770
code review (dart.lineLength)
okmsbun Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/src/model/common/node.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,24 @@ abstract class Node {
bool prepend = false,
}) {
final pos = nodeAt(path).position;
final (newPos, newSan) = pos.makeSan(move);
final (newPos, newSan) = pos.makeSan(convertAltCastlingMove(move) ?? move);
final newNode = Branch(
sanMove: SanMove(newSan, move),
sanMove: SanMove(newSan, convertAltCastlingMove(move) ?? move),
position: newPos,
);
return addNodeAt(path, newNode, prepend: prepend);
}

/// The function `convertAltCastlingMove` checks if a move is an alternative
/// castling move and converts it to the corresponding standard castling move if so.
Move? convertAltCastlingMove(Move move) {
return altCastles.containsValue(move.uci)
? Move.fromUci(
altCastles.entries.firstWhere((e) => e.value == move.uci).key,
)
: move;
}

/// Deletes the node at the given path.
void deleteAt(UciPath path) {
parentAt(path).children.removeWhere((child) => child.id == path.last);
Expand Down
53 changes: 53 additions & 0 deletions test/model/common/node_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,59 @@ void main() {
),
);
});
group('convert alternative castling move', () {
void makeTestAltCastlingMove(String pgn, String alt1, String alt2) {
final root = Root.fromPgnGame(PgnGame.parsePgn(pgn));
final initialPath = root.mainlinePath;
final initialPng = root.makePgn();

final move = Move.fromUci(alt1);
expect(move, isNotNull);

final newMove = root.convertAltCastlingMove(move!);
expect(newMove, isNotNull);
expect(newMove, Move.fromUci(alt2));
expect(root.mainline.last.sanMove.move, newMove);

final previousUciPath = root.mainlinePath.penultimate;
final (newPath, isNewNode) = root.addMoveAt(previousUciPath, move);
expect(newPath, initialPath);
expect(isNewNode, isFalse);
expect(root.makePgn(), initialPng);
}

test('e1g1 -> e1h1', () {
makeTestAltCastlingMove(
'1. e4 e5 2. Nf3 Nf6 3. Bc4 Bc5 4. O-O',
'e1g1',
'e1h1',
);
});

test('e8g8 -> e8h8', () {
makeTestAltCastlingMove(
'1. e4 e5 2. Nf3 Nf6 3. Bc4 Bc5 4. O-O O-O',
'e8g8',
'e8h8',
);
});

test('e1c1 -> e1a1', () {
makeTestAltCastlingMove(
'1. d4 d5 2. Nc3 Nc6 3. Be3 Be6 4. Qd3 Qd6 5. O-O-O',
'e1c1',
'e1a1',
);
});

test('e8c8 -> e8a8', () {
makeTestAltCastlingMove(
'1. d4 d5 2. Nc3 Nc6 3. Be3 Be6 4. Qd3 Qd6 5. O-O-O O-O-O',
'e8c8',
'e8a8',
);
});
});
});
}

Expand Down