Skip to content

Conversation

@julien4215
Copy link
Collaborator

@julien4215 julien4215 commented Jan 30, 2024

Closes #437

Screenshot

@HaonRekcef
Copy link
Contributor

Do we want to utilize vertical space for this? I'd prefer the text to be vertical, similar to the layout in the lichobile app and on lichess.

@veloce
Copy link
Contributor

veloce commented Jan 31, 2024

Yes that would be better, and with a smaller font size too.

@julien4215
Copy link
Collaborator Author

I also wanted to put the text vertically but the library FL Chart doesn't give this option. Should I create an issue on their GitHub ?

@veloce
Copy link
Contributor

veloce commented Jan 31, 2024

Yep, sure. If it's not too difficult you could maybe also submit a PR in their repo to boost the process? Otherwise I don't think we'll merge this, as to me vertical font is mandatory.

@veloce
Copy link
Contributor

veloce commented Feb 2, 2024

Perhaps we can still merge this after all, but font size should be smaller and if possible the lines thinner. Also they could be of same color as in lichess website.

@julien4215
Copy link
Collaborator Author

I made the lines thinner and I took the same color that is in lichess website. I also made the font smaller.

Yep, sure. If it's not too difficult you could maybe also submit a PR in their repo to boost the process? Otherwise I don't think we'll merge this, as to me vertical font is mandatory.

Sure I'll look at their repo and try to make a PR.

@julien4215
Copy link
Collaborator Author

I made the PR imaNNeo/fl_chart#1579.

@veloce veloce merged commit 56e3205 into lichess-org:main Feb 6, 2024
@julien4215 julien4215 deleted the game-phases-chart branch February 7, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add game phases to summary chart

3 participants