fix: add start game sound #891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloce
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Thanks for contributing.
There is some logic to fix here. But I'm still not sure whether we want this or not.
|
|
||
| _socketEventVersion = fullEvent.socketEventVersion; | ||
|
|
||
| if (game.status == GameStatus.started && game.steps.length == 1) { |
There was a problem hiding this comment.
The logic here should be more complicated than that.
One needs to ensure:
- you are playing this game and not spectating it
- you have not played a moved yet (so depending on the side, 0 or 1 move was played)
There was a problem hiding this comment.
you have not played a moved yet (so depending on the side, 0 or 1 move was played)
Not sure about that one - the web UI also seems to play the sound only if no move has been played at all yet.
|
@Lonec-L Are you still planning to work on this? Otherwise I might take a look at this myself |
|
I am not planning to work on this, so go ahead
Dne sob., 9. nov. 2024 ob 10:35 je Tom Praschan ***@***.***>
napisal/-a:
… @Lonec-L <https://github.com/Lonec-L> Are you still planning to work on
this? Otherwise I might take a look at this myself
—
Reply to this email directly, view it on GitHub
<#891 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFVFTHFNDGHBAUFR5BLLXDZ7XJNXAVCNFSM6AAAAABLU5CPVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGE2DMMRZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #890
Checks if the game just started in the first
'full'game event handler and plays the start game sound.Since the first
'full'event is always handled here, and we always receive a'full'event when connecting to a new game, this seemed like an appropriate place for playing the starting sound.