Skip to content

fix: add start game sound #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add start game sound #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/src/model/game/game_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ class GameController extends _$GameController {

_socketEventVersion = fullEvent.socketEventVersion;

if (game.status == GameStatus.started && game.steps.length == 1) {
Copy link
Contributor

@veloce veloce Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here should be more complicated than that.

One needs to ensure:

  • you are playing this game and not spectating it
  • you have not played a moved yet (so depending on the side, 0 or 1 move was played)

Copy link
Collaborator

@tom-anders tom-anders Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have not played a moved yet (so depending on the side, 0 or 1 move was played)

Not sure about that one - the web UI also seems to play the sound only if no move has been played at all yet.

ref.read(soundServiceProvider).play(Sound.dong);
}

return GameState(
gameFullId: gameFullId,
game: game,
Expand Down