tweak idempotent build strategy #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
675bc9e to
bd34ba6
Compare
rerun-if-changed exactly the copied Stockfish files. This way there is no way to miss newly introduced dependencies (like Stockfish/**/*.sh). Deterministically choose subdirectory in OUT_PATH as Stockfish build dir, based on the list of source files (but not their contents). No longer attempt to clean up OUT_PATH. Stale data only remains when Stockfish changes the file structure. Without cleanup, NNUE backups are no longer required. Remove deletion of corrupted (e.g., partially downloaded) NNUE files. Stockfish build scripts now handle this. Optionally, NNUE files downloaded manually in the source directory will also be copied and treated as source files, so that fishnet can be built offline.
Co-authored-by: Álvaro Cuesta <1827495+alvaro-cuesta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rerun-if-changedexactly the copied Stockfish files. This way there is no way to miss newly introduced dependencies (likeStockfish/**/*.sh).Deterministically choose subdirectory in
OUT_PATHas Stockfish build dir, based on the list of source files (but not their contents). No longer attempt to clean upOUT_PATH. Stale data only remains when Stockfish changes the file structure.Without cleanup, NNUE backups are no longer required.
Remove deletion of corrupted (e.g., partially downloaded) NNUE files. Stockfish build scripts now handle this.
Optionally, NNUE files downloaded manually in the source directory will also be copied and treated as source files, so that fishnet can be built offline.