fix: hint for submodule init on fresh repo #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodules need to be initialized before building on a fresh repo. There is an error message indicating this, but lichess-org#278 introduced a bug where the warning is not shown anymore. The root cause is that submodules are (empty) directories even if not yet initialized so checking if "submodule" is a directory always passes. Instead it should check "submodule/src", which should only exist if the submodule has been initialized.
|
Apologies for introducing this issue, should've tested on a fresh repo! |
|
Thanks! No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodules need to be initialized before building on a fresh repo. There is an error message indicating this, but #278 introduced a bug where the warning is not shown anymore.
The root cause is that submodules are (empty) directories even if not yet initialized so checking if "submodule" is a directory always passes. Instead it should check "submodule/src", which should only exist if the submodule has been initialized.
I just saw #280 which supersedes #278 but I still posted this PR for the record and because the change is tiny, so it's probably safe to merge the fix.