fix: Fairy-Stockfish build fails on MacOS Tahoe 26 #282
Conversation
`clang++` fails with: ``` clang++: error: unknown argument: '-fexperimental-new-pass-manager' ``` Bumping Fairy-Stockfish submodule fixes the issue.
There was a problem hiding this comment.
Bumped Fairy-Stockfish to latest master but not sure what the update policy is or whether this could be a breaking change.
This is the minimum Fairy-Stockfish commit that would fix the issue: fairy-stockfish/Fairy-Stockfish@052dce6
| path: fishnet-x86_64-apple-darwin | ||
| macos-aarch64: | ||
| runs-on: macos-13 | ||
| runs-on: macos-26 |
There was a problem hiding this comment.
Added this to PR so we can consider the potential change. This would've caught the issue in CI.
The Apple Silicon build is currently running on macos-13 which is (1) Intel and (2) soon to be deprecated in a month. Is there any reason Apple Silicon was built on an Intel runner?
Changed to macos-26 just because it's the latest (and matches the environment where I found this issue!) but it's currently marked as "public preview" in GH docs. It should still be a good idea to update this at least to macos-14 due to the deprecation (macos-15 being the latest non-preview runner) and to build natively on Apple Silicon. macos-15 is also the minimum runner that has Clang 16 which would have caught this issue in CI.
Also note that the macos-x86-64 job is also using macos-13 and should probably be updated to macos-15-intel (which will also be deprecated in GH by Aug 2027) or cross-compile from an Apple Silicon runner.
Additionally: right below these lines there's...
CXXFLAGS: -target arm64-apple-macos11
I guess it was there because it was cross-compiling from Intel to Apple Silicon, but I still didn't touch it because that 11 makes me think there are breaking changes for binaries built targetting different MacOS versions?
Also note that the macos-x86-64 job is not specifying any CXXFLAGS so it might need a change to keep the target stable if macos-13 runner is changed.
|
I think the binaries for Windows and MacOS don't end up being fully static. So the strategy so far was just to use the oldest still available build environment, for maximum compatibility. We can and should update Fairy-Stockfish. |
|
Cherry-picked the submodule bump for now. |
|
@niklasf apologies for not following up, been pretty busy lately. Thanks for the bump. |
clang++in MacOS Tahoe 26.0.1 fails with:This is due to
clang>= 16 no longer supporting that flag.Bumping Fairy-Stockfish submodule fixes the issue.