-
-
Notifications
You must be signed in to change notification settings - Fork 109
fix: Fairy-Stockfish build fails on MacOS Tahoe 26 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
alvaro-cuesta
wants to merge
2
commits into
lichess-org:master
from
alvaro-cuesta:fix/build-macos-tahoe
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule Fairy-Stockfish
updated
from f3e696 to a80921
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to PR so we can consider the potential change. This would've caught the issue in CI.
The Apple Silicon build is currently running on
macos-13which is (1) Intel and (2) soon to be deprecated in a month. Is there any reason Apple Silicon was built on an Intel runner?Changed to
macos-26just because it's the latest (and matches the environment where I found this issue!) but it's currently marked as "public preview" in GH docs. It should still be a good idea to update this at least tomacos-14due to the deprecation (macos-15being the latest non-preview runner) and to build natively on Apple Silicon.macos-15is also the minimum runner that has Clang 16 which would have caught this issue in CI.Also note that the
macos-x86-64job is also usingmacos-13and should probably be updated tomacos-15-intel(which will also be deprecated in GH by Aug 2027) or cross-compile from an Apple Silicon runner.Additionally: right below these lines there's...
I guess it was there because it was cross-compiling from Intel to Apple Silicon, but I still didn't touch it because that
11makes me think there are breaking changes for binaries built targetting different MacOS versions?Also note that the
macos-x86-64job is not specifying anyCXXFLAGSso it might need a change to keep the target stable ifmacos-13runner is changed.