Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
name: fishnet-x86_64-apple-darwin
path: fishnet-x86_64-apple-darwin
macos-aarch64:
runs-on: macos-13
runs-on: macos-26
Copy link
Contributor Author

@alvaro-cuesta alvaro-cuesta Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to PR so we can consider the potential change. This would've caught the issue in CI.

The Apple Silicon build is currently running on macos-13 which is (1) Intel and (2) soon to be deprecated in a month. Is there any reason Apple Silicon was built on an Intel runner?

Changed to macos-26 just because it's the latest (and matches the environment where I found this issue!) but it's currently marked as "public preview" in GH docs. It should still be a good idea to update this at least to macos-14 due to the deprecation (macos-15 being the latest non-preview runner) and to build natively on Apple Silicon. macos-15 is also the minimum runner that has Clang 16 which would have caught this issue in CI.


Also note that the macos-x86-64 job is also using macos-13 and should probably be updated to macos-15-intel (which will also be deprecated in GH by Aug 2027) or cross-compile from an Apple Silicon runner.


Additionally: right below these lines there's...

CXXFLAGS: -target arm64-apple-macos11

I guess it was there because it was cross-compiling from Intel to Apple Silicon, but I still didn't touch it because that 11 makes me think there are breaking changes for binaries built targetting different MacOS versions?

Also note that the macos-x86-64 job is not specifying any CXXFLAGS so it might need a change to keep the target stable if macos-13 runner is changed.

permissions:
contents: read
env:
Expand Down
2 changes: 1 addition & 1 deletion Fairy-Stockfish
Loading