add lichess profile link and change subscribe button style #12780
Conversation
|
No sure, wouldn't it make more sense to style the big lichess username at the top and turn into a link instead of adding a new button? Not sure if people would be confused about it when it redirects to lichess profile instead of streamer page. |
|
It's an interesting aproach, i tried to stick with the original idea in #12164:
This way we win more space an get a cleaner layout. As drawbacks we don't see the users name or if he's online, only his streamer name, furthermore as you pointed out maybe it's strange to click on the streamer name an go to he's lichess profile instead of the streamer page. To be honest i'm not sure what's best. More feedback would be apreciated. |
|
I like the implementation in your original commit. Failing that, a blue text link "Go to profile..." beside the subscribe button also works. Their streamer name can be different than their username. It's definitely strange to use as a profile link. |
You're right, was confused by the title displayed, my bad |
|
Note that there already is a profile link in the list, after the YT and/or Twitch link. But it's definitely not super obvious. But it should definitely be removed if you add a link elsewhere. |
|
The profile link has been removed from the list in the last commit. |
ui/common/css/form/_cmn-toggle.scss
Outdated
| @extend %double-tap; | ||
| position: absolute; | ||
| margin-#{$start-direction}: -99999px; | ||
| visibility: hidden; |
There was a problem hiding this comment.
this defeats the accessibility setup of the button, and prevents it from being read by screen readers
There was a problem hiding this comment.
I had no idea about the accessibility problems, sorry for that, but the issue if you just remove that property is that in some languages like arab where te button aligns right you can see the checkbutton behind the label.
* master: (60 commits) New Crowdin updates (lichess-org#12796) regen piece sprite after lichess-org#12815 recreate source branch for voice merge Mpchess black knight adjustment add /api/study/by/:user endpoint tweak study controllers and ratelimiting move glyphs json to modules/study fix autocompletion of members of a team with hidden listings scala code golf Add results to broadcast multiboard in real-time better type `StudyChapterMeta.res` fix eslint, use const for `playerWhoMoved` scala code golf remove debug remove `ChapterPreview.sideToPlay` as it can be computed client-side cheaply extract and refactor `fenColor` to `common/mini-game` don't select games with anon in mod games view Update clocks when moves are received by websocket Update play-json to 2.10.0-RC8 Adjust 2FA wording: 'secret' -> 'secret key' ...
|
it doesn't look great tbh, but was already quite bad before, so... |
References #12164
Adds a profile link in the streamer's overview and styles the subscribe button a bit, to make it consistent with the other toggle switch buttons.
Old:
New:
I think that the toggle switch button shouldn't be inside of a regular button, it feels to crowded. Furthemore it's consistent with the other switch buttons like the ones in "Edit streamer page".