Use CSS to fix how dates are displayed in RTL languages #13474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's very nice, but I think we should go farther and move the CSS to the CSS files. We already have common styling for all lila/ui/common/css/base/_elements.scss Line 59 in ddc248d |
c63cb40 to
84bd04e
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #13461 (review), I have updated the fix to use CSS only.
Moreover, I have updated the fix so that the username appears beside the donor badge. I also validated the order of the date components with Google Translate: it should be
<year> <month> <day>in RTL languages (e.g. Arabic, Farsi, Urdu).Before:
After:
