Skip to content

Use CSS to fix how dates are displayed in RTL languages #13474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Use CSS to fix how dates are displayed in RTL languages #13474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84bd04e
Use CSS to fix how dates are displayed in RTL languages
shermansiu Aug 28, 2023
53126d1
Use class styles instead of inline styles.
shermansiu Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions app/templating/DateHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import play.api.i18n.Lang
import java.time.format.{ FormatStyle, DateTimeFormatter }
import java.time.{ Duration, LocalDate }

import lila.app.ui.ScalatagsTemplate.{*, given}
import lila.app.ui.ScalatagsTemplate.*
import lila.i18n.PeriodLocales

trait DateHelper:
Expand Down Expand Up @@ -50,16 +50,10 @@ trait DateHelper:
def showEnglishInstant(instant: Instant): String = englishDateTimeFormatter print instant

def semanticDate(instant: Instant)(using lang: Lang): Tag =
timeTag(
datetimeAttr := isoDateTime(instant),
dir := isRTL.option("rtl")
)(showDate(instant))
timeTag(datetimeAttr := isoDateTime(instant))(showDate(instant))

def semanticDate(date: LocalDate)(using lang: Lang): Tag =
timeTag(
datetimeAttr := isoDateTime(date.atStartOfDay.instant),
dir := isRTL.option("rtl")
)(showDate(date))
timeTag(datetimeAttr := isoDateTime(date.atStartOfDay.instant))(showDate(date))

def showMinutes(minutes: Int)(using Lang): String =
showDuration(Duration.ofMinutes(minutes))
Expand Down
1 change: 1 addition & 0 deletions ui/common/css/base/_elements.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ time {
opacity: 0.9;

/* don't use c-color-dim, it overrides too hard */
unicode-bidi: plaintext;
}

hr {
Expand Down
3 changes: 3 additions & 0 deletions ui/site/css/ublog/_post.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
margin-#{$start-direction}: -0.5rem;
vertical-align: top;
}
&__date {
unicode-bidi: embed;
}
}
&__topics {
@extend %flex-wrap;
Expand Down