-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix study pinned comment spelling typo #13489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix study pinned comment spelling typo #13489
Conversation
|
Thanks. Fixing the inconsistency the other way around ( |
|
Hint: lila/ui/analyse/src/study/description.ts Line 29 in e744bb6
|
|
Just to clarify, is the correct phrasing 'Pinned chapter comment' or still 'Chapter pinned comment' in the case where it is chapter instead of study. |
|
|
i.e. "Pinned chapter comment" is better. |
Also, I'm not convinced that the original issue has been properly configured to auto-close upon the fix's merge. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
I believe I used the keyword 'fix' and linked the issue. Is there anything else I need to do? |
The syntax doesn't match. Use |
|
You will know that the PR has been properly linked when you go to the issue page and see the PR linked in the "Development" section in the sidebar to the right with the text "Successfully merging a pull request may close this issue." |
|
Got it, thank you |
Fix #13480.