Skip to content

Conversation

@kwang03
Copy link
Contributor

@kwang03 kwang03 commented Aug 30, 2023

Fix #13480.

@niklasf
Copy link
Member

niklasf commented Aug 30, 2023

Thanks. Fixing the inconsistency the other way around (Pinned study comment) makes more sense to me. It's the pinned comment describing the study, not the action to study a pinned comment.

@shermansiu
Copy link
Contributor

Hint:

export const descTitle = (chapter: boolean) => `${chapter ? 'Chapter' : 'Study'} pinned comment`;

@kwang03
Copy link
Contributor Author

kwang03 commented Sep 2, 2023

Just to clarify, is the correct phrasing 'Pinned chapter comment' or still 'Chapter pinned comment' in the case where it is chapter instead of study.

@shermansiu
Copy link
Contributor

`Pinned ${chapter ? 'chapter' : 'study'} comment`; 

@shermansiu
Copy link
Contributor

shermansiu commented Sep 2, 2023

i.e. "Pinned chapter comment" is better.

@shermansiu
Copy link
Contributor

Fix issue #13480.

Also, I'm not convinced that the original issue has been properly configured to auto-close upon the fix's merge. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@kwang03
Copy link
Contributor Author

kwang03 commented Sep 2, 2023

Fix issue #13480.

Also, I'm not convinced that the original issue has been properly configured to auto-close upon the fix's merge. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

I believe I used the keyword 'fix' and linked the issue. Is there anything else I need to do?

@shermansiu
Copy link
Contributor

Fix issue #13480.

Also, I'm not convinced that the original issue has been properly configured to auto-close upon the fix's merge. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

I believe I used the keyword 'fix' and linked the issue. Is there anything else I need to do?

The syntax doesn't match. Use KEYWORD #ISSUE-NUMBER. i.e. Edit the description and remove the word "issue" so that it becomes "Fix #13480".

@shermansiu
Copy link
Contributor

You will know that the PR has been properly linked when you go to the issue page and see the PR linked in the "Development" section in the sidebar to the right with the text "Successfully merging a pull request may close this issue."

@kwang03
Copy link
Contributor Author

kwang03 commented Sep 2, 2023

Got it, thank you

@ornicar ornicar merged commit b40d378 into lichess-org:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Study pinned comment" typo

4 participants