Skip to content

Conversation

@M-DinhHoangViet
Copy link
Contributor

fixes #14149

@M-DinhHoangViet M-DinhHoangViet marked this pull request as draft December 6, 2023 06:33
@M-DinhHoangViet M-DinhHoangViet changed the title Translate showUnreadLichessMessage text Translate messages and warnings Dec 6, 2023
@ornicar
Copy link
Collaborator

ornicar commented Dec 6, 2023

Don't forget to set the PR as "Ready for review" when it's ready for review. I.e. when you have tested it yourself.

@M-DinhHoangViet
Copy link
Contributor Author

Hello, according to my title edit, this PR is not complete. I'll do it soon and test it thoroughly

@ornicar
Copy link
Collaborator

ornicar commented Dec 6, 2023

cool, no hurry

@M-DinhHoangViet
Copy link
Contributor Author

M-DinhHoangViet commented Dec 6, 2023

It is expected that this PR will probably be completed in about 1 week because there are many messages and warnings that are not displayed by normal means.
If you want to merge these changes first then I'm open for you to merge

@M-DinhHoangViet M-DinhHoangViet changed the title Translate messages and warnings translate showUnreadLichessMessage text Dec 12, 2023
@M-DinhHoangViet M-DinhHoangViet marked this pull request as ready for review December 12, 2023 08:12
@M-DinhHoangViet
Copy link
Contributor Author

Sorry @ornicar , let's merge this first. I'm very busy right now

@ornicar ornicar merged commit e7a40d5 into lichess-org:master Dec 12, 2023
@M-DinhHoangViet M-DinhHoangViet deleted the translate-showUnreadLichessMessage-text branch December 12, 2023 09:27
ornicar added a commit to schlawg/lila that referenced this pull request Dec 14, 2023
* master:
  translate showUnreadLichessMessage text (lichess-org#14158)
  add puzzle streak and racer flairs
  add puzzle racer and streak flairs to list
  only lowercase user (based on feedback)
  reword showRatings explanation
  update grammar
  update
  remove redundant words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate showUnreadLichessMessage text

2 participants