Skip to content

translation xml sheet changes #14190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 12, 2023
Merged

translation xml sheet changes #14190

merged 5 commits into from
Dec 12, 2023

Conversation

@TheForkPower
Copy link
Contributor

@TheForkPower TheForkPower commented Dec 8, 2023

some quick changes I made for conciseness (used helperbird Grammarly paraphrasers). also a native UK English speaker

fitztrev
fitztrev reviewed Dec 9, 2023
View reviewed changes
@TheForkPower
Copy link
Contributor Author

TheForkPower commented Dec 9, 2023

yep OK! I'll edit.

fitztrev
fitztrev approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@fitztrev fitztrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they look good. Only one that might not be clear is drawStreakStandard, but it wasn't very clear before, regardless if there's a comma or not. Maybe that should be rewritten but it might be better to propose in a different PR.

@ornicar ornicar merged commit 1e53f44 into lichess-org:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fitztrev fitztrev fitztrev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheForkPower @fitztrev @ornicar