- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.5k
 
Input Moves With Keyboard to Include Berserk #14492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! a few comments. Not familiar with jest so cannot say about the test
* 'patch-5' of https://github.com/Carbrex/lila: Fixed formatting Fixed berserk sound playing even when round doesn't support berserk Fixed berserk sound playing even when round doesn't support berserk Added condition for playing berserk sound
          
 How did you set up a localised version of lichess? Is there any tutorial on how to do it on youtube?  | 
    
          
 You can use https://github.com/lichess-org/lila-docker or https://github.com/lichess-org/lila-gitpod for the easiest setup.  | 
    
Added berserk to keyboard input shortcuts. Closes #14480 . The berserk functionality is working correctly, but I am not sure about the test I included for berserk. Can you please verify that is it correct.
Li.Admin.Arena.QnDAovnb.lila.-.Google.Chrome.2024-01-17.18-24-55_Trim.mp4