Skip to content

Conversation

@Carbrex
Copy link
Member

@Carbrex Carbrex commented Jan 17, 2024

Added berserk to keyboard input shortcuts. Closes #14480 . The berserk functionality is working correctly, but I am not sure about the test I included for berserk. Can you please verify that is it correct.

Li.Admin.Arena.QnDAovnb.lila.-.Google.Chrome.2024-01-17.18-24-55_Trim.mp4

Copy link
Member

@kraktus kraktus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! a few comments. Not familiar with jest so cannot say about the test

@Carbrex Carbrex marked this pull request as draft January 18, 2024 18:01
@Carbrex Carbrex marked this pull request as ready for review January 18, 2024 18:13
* 'patch-5' of https://github.com/Carbrex/lila:
  Fixed formatting
  Fixed berserk sound playing even when round doesn't support berserk
  Fixed berserk sound playing even when round doesn't support berserk
  Added condition for playing berserk sound
@ornicar ornicar merged commit a887daf into lichess-org:master Jan 18, 2024
@cFlour
Copy link

cFlour commented Feb 15, 2024

Li.Admin.Arena.QnDAovnb.lila.-.Google.Chrome.2024-01-17.18-24-55_Trim.mp4

How did you set up a localised version of lichess? Is there any tutorial on how to do it on youtube?

@Carbrex
Copy link
Member Author

Carbrex commented Feb 15, 2024

How did you set up a localised version of lichess? Is there any tutorial on how to do it on youtube?

You can use https://github.com/lichess-org/lila-docker or https://github.com/lichess-org/lila-gitpod for the easiest setup.
Else follow https://github.com/lichess-org/lila/wiki/Lichess-Development-Onboarding these instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input Moves With Keyboard to Include Berserk

4 participants