Update animation duration of chess clock bar when player receives mor… #15243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i notice the linter failure. in these situations i am used to making fixes then ammending my commit and force pushing to my own fork, can i do that here? |
|
Yes 👍 |
…e time than the initial duration of the animation
|
Very nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is intended to address issue #15102
in the event that the player gets more time than the animation's duration (the clock 'bar time') the approach here makes it so that the bar does not start animating until the player's clock has decreased sufficiently to the initial bartime. i attached a short video below of a 1+0 bullet game to demonstrate
timebar_gif.mp4