Skip to content

Alert the user when exceeding the pgn import limit #16626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 20, 2024
Merged

Alert the user when exceeding the pgn import limit #16626

merged 6 commits into from
Dec 20, 2024

Conversation

@johndoknjas
Copy link
Contributor

@johndoknjas johndoknjas commented Dec 19, 2024

Resolves #16575.

schlawg
schlawg suggested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@schlawg schlawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use the system alert/confirm/prompt because they pause the event loop.

import { alert } from 'common/dialog';

at the top of ui/analyse/src/study/chapterNewForm.ts to use ours.

schlawg
schlawg approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@schlawg schlawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@schlawg schlawg merged commit d86fc01 into lichess-org:master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schlawg schlawg schlawg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

silent failure when study pgn import rate limit exceeded

2 participants

@johndoknjas @schlawg