Skip to content

Alert the user when exceeding the pgn import limit #16626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Alert the user when exceeding the pgn import limit #16626

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d8c6df
Give an alert when the user tries to exceed the 1000 pgn imports per …
johndoknjas Dec 19, 2024
75942cc
Merge branch 'master' into import-limit-notify
johndoknjas Dec 19, 2024
c2c301b
Use ===
johndoknjas Dec 19, 2024
893db93
Merge remote-tracking branch 'origin/import-limit-notify' into import…
johndoknjas Dec 19, 2024
2da9a2d
Use the custom lichess `alert`.
johndoknjas Dec 20, 2024
bb7091f
Merge branch 'master' into import-limit-notify
johndoknjas Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ui/analyse/src/study/chapterNewForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { parseFen } from 'chessops/fen';
import { defined, prop, type Prop, toggle } from 'common';
import { snabDialog } from 'common/dialog';
import { snabDialog, alert } from 'common/dialog';
import * as licon from 'common/licon';
import { bind, bindSubmit, onInsert, looseH as h, dataIcon, type VNode } from 'common/snabbdom';
import { storedProp } from 'common/storage';
Expand Down Expand Up @@ -85,7 +85,11 @@ export class StudyChapterNewForm {
const study = this.root.study!;
const dd = { ...d, sticky: study.vm.mode.sticky, initial: this.initial() };
if (!dd.pgn) this.send('addChapter', dd);
else importPgn(study.data.id, dd);
else
importPgn(study.data.id, dd).catch(e => {
if (e.message === 'Too many requests') alert('Limit of 1000 pgn imports every 24 hours');
throw e;
});
this.isOpen(false);
this.setChaptersTab();
};
Expand Down
Loading