Hide broadcast results in the single board view #16799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A side note: are the checkboxes 'playing' and 'results' necessary in studies (when they are not a broadcast) ? |
`ctrl.study?.multiBoard.showResults` can never be undefined
again `ctrl.study.multiBoard.showResults` can't be undefined
yafred
commented
Jan 21, 2025
| const ctx: Ctx = { | ||
| ...renderingCtx(ctrl), | ||
| concealOf: concealOf ?? emptyConcealOf, | ||
| onlyHide: ctrl.study?.relay !== undefined ? true : false, |
I don't understand what it does, and I see no functional difference after removing it.
|
Did I miss something in that last commit? |
Short answer: no, it is great as it is Long answer: I added them after I tested with the PGN's from https://lichess.org/broadcast/tata-steel-chess-2025--masters/round-1/HmnX0y6b#boards The fixes you made must have removed the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends PR #16650
fixes issue #16786
With 'Results' un-checked: