Do not have the client engine use the server eval #17061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the evaluation logic used in the client engine to avoid displaying the server evaluation. Key changes include:
- Using optional chaining to simplify the conditional check in the threat button.
- Replacing the complex getBestEval logic with a simplified one-liner that prioritizes the client evaluation.
Reviewed Changes
| File | Description |
|---|---|
| ui/ceval/src/view/main.ts | Simplified evaluation selection and cleanup of unused serverNodes. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
ui/ceval/src/view/main.ts:119
- The new implementation of getBestEval always returns evs.client if it is truthy, bypassing the previously detailed logic that considered mate values and node counts. Confirm that this simplified behavior is intended for the client engine evaluation.
export const getBestEval = (evs: NodeEvals): EvalScore | undefined => evs.client || evs.server;
ui/ceval/src/view/main.ts:116
- The variable serverNodes is now unused after simplifying getBestEval. Consider removing it to keep the code clean.
const serverNodes = 4e6;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to only affect the evaluation shown by the running engine, and temporarily the evals given to moves in the notation (until refreshing). I could be wrong though.
For why we might want to consider this:
The reason for this is that the SF 17 server analysis is used for the main bold eval, until the client engine reaches 4 million nodes. But for the user this feels confusing; especially if they're using SF 16 on their end, the abrupt change in evaluation can be large.
This isn't as much of a problem when the number of lines is just 1, since in that case no evaluation is displayed for the line. However, it's still not fully candid, since initially the main evaluation in bold won't necessarily correspond with the current line given.