Skip to content

Do not have the client engine use the server eval #17061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Do not have the client engine use the server eval #17061

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42f9b96
Do not use the server eval when the client engine is running.
johndoknjas Feb 26, 2025
38bcfb7
Merge branch 'master' into eval-discrepancy
johndoknjas Feb 26, 2025
05c499f
Merge branch 'master' into eval-discrepancy
johndoknjas Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions ui/ceval/src/view/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function localInfo(ctrl: ParentCtrl, ev?: Tree.ClientEval | false): EvalInfo {
}

function threatButton(ctrl: ParentCtrl): VNode | null {
if (ctrl.getCeval().download || (ctrl.disableThreatMode && ctrl.disableThreatMode())) return null;
if (ctrl.getCeval().download || ctrl.disableThreatMode?.()) return null;
return h('button.show-threat', {
class: { active: ctrl.threatMode(), hidden: !!ctrl.getNode().check },
attrs: { 'data-icon': licon.Target, title: i18n.site.showThreat + ' (x)' },
Expand Down Expand Up @@ -116,25 +116,7 @@ function engineName(ctrl: CevalCtrl): VNode[] {
: [];
}

const serverNodes = 4e6;

export function getBestEval(evs: NodeEvals): EvalScore | undefined {
const serverEv = evs.server,
localEv = evs.client;

if (!serverEv) return localEv;
if (!localEv) return serverEv;

// Prefer localEv if it exceeds fishnet node limit or finds a better mate.
if (
localEv.nodes > serverNodes ||
(typeof localEv.mate !== 'undefined' &&
(typeof serverEv.mate === 'undefined' || Math.abs(localEv.mate) < Math.abs(serverEv.mate)))
)
return localEv;

return serverEv;
}
export const getBestEval = (evs: NodeEvals): EvalScore | undefined => evs.client || evs.server;

export function renderGauge(ctrl: ParentCtrl): VNode | undefined {
if (ctrl.ongoing || !ctrl.showEvalGauge()) return;
Expand Down