Don't give draw claims as explanations for imported games #17191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l agreement) are incorrectly reported as insufficient material claims.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR applies a fix for games whose
Sourceis 'imported'. I'm not sure if aSourceval of 'local' can also refer to games played off lichess; if so, they should be included in this PR too.For Masters DB games, if the players agreed to a draw by mutual agreement, the game is incorrectly labelled as a draw claim by insufficient material. E.g.:
This is due to #17114, where I incorrectly assumed control flows reaching this point in the code could only be draws by insufficient material claims. However, imported games in the Masters DB aren't obliged to provide specific draw info, so they can also reach this point.