Skip to content

Conversation

@yafred
Copy link
Contributor

@yafred yafred commented Apr 30, 2025

Fixes #17412

In the nvui interface clocks are rendered in 2 ways:

  1. In the analyse view, same as for sighted HH:MM:SS (for example 01:30:10)
  2. In playing mode nnH:nnM:nnS (for example 1H:30M:10S)

This PR unifies and verbalizes the 2.
It also uses the correspondence clock everywhere: display maximum 2 components of the clock (day-hour or hour-minute or minute-seconds)

Examples:
01:30:10 is now rendered as 1 hour, 30 minutes
04:30 is now rendered as 4 minutes, 30 seconds

There are many advantages to verbalize the clock:

  • helps TTS that could interpret the HH:MM in a weird way
  • helps new players because 1 hour is clearer than 01H
  • benefits from existing translations

@yafred yafred marked this pull request as ready for review April 30, 2025 18:14
@yafred yafred changed the title Render clock in a verbal way Render clock in a verbal way - nvui Apr 30, 2025
@ornicar
Copy link
Collaborator

ornicar commented May 2, 2025

please make sure that I can push to the PR. I'll make the amends on master.

@ornicar ornicar merged commit 06e97b6 into lichess-org:master May 2, 2025
3 checks passed
ornicar added a commit that referenced this pull request May 2, 2025
@yafred yafred deleted the 17412-nvui-clocks branch May 2, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvui clock announcement issue

2 participants