- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.5k
 
Announce all pieces by color #17687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announce all pieces by color #17687
Conversation
| 
           Great idea. This would be useful.  | 
    
| 
           @yafred The way this change was made (updating source string text) does not inform translators. It appears only in Crowdin's activity stream. Are you comfortable that it's not necessary for existing translations to be re-worked to include this example please? Edit: while you are at it, could you please also consider if this older rewording would need new translations too?  | 
    
| 
           Thanks for the heads-up ... I'll keep that in mind in the future. Whatever way we choose (crowdin or source code), there is windows where we loose the translations ?  | 
    
          
 Not sure I totally understand the question. If you are asking whether we would have to lose some translations in order to change them - then yes, translators would be able to access the past string using the translation memory if it is close enough. As a principle, if the actual meaning of a string changes, we should be introducing a separate string variable. With that in mind, do you think these can continue to exist as-is or should they be recreated in source/have older translations purged on Crowdin manually?  | 
    
| 
           If it's not too much work, I think it's better to do it on Crowdin ... Let me explain what I was asking  with an example:  | 
    
          
 It is a lot of work which is why I'm a bit apprehensive. 😅 It involves manually noting down who translated what to ask them to revisit the string, and there is no easy functionality to create a list of names to pass to Crowdin's message interface for instance. So I'd have to click through dozens of langauges, write down names, and then type them in manually to the 'Members' tab (as they must be contacted via the project, not directly, per on-platform anti-spam rules). As an alternative, could the string be introduced in the code (in   | 
    
| 
           Too much work is a bad thing ... Is it what you had in mind ... if yes, I'm ok with that  | 
    
          
 Sounds good, though I would also say you do not need step to revert the source English keys, you can just introduce the new keys.  | 
    
fixes #17658
A pseudo piece A (like all) is added to p command
p a will announce where black pieces are
the same way
p n announces where black knight is