nvui - explore diagonals on the board #17701
Conversation
translation/source/nvui.xml
Outdated
| <string name="top" comment="direction of a ray">top</string> | ||
| <string name="topRight" comment="direction of a ray">top right</string> | ||
| <string name="right" comment="direction of a ray">right</string> | ||
| <string name="bottomRight" comment="direction of a ray">bottom right</string> | ||
| <string name="bottom" comment="direction of a ray">bottom</string> | ||
| <string name="bottomLeft" comment="direction of a ray">bottom left</string> | ||
| <string name="left" comment="direction of a ray">left</string> | ||
| <string name="topLeft" comment="direction of a ray">top left</string> |
There was a problem hiding this comment.
I'd be apprehensive about adding new (and so many!) translations along with new features. Let it bake for a month or two and if there's no bad feedback about wording, set a reminder and make a separate translations PR.
There was a problem hiding this comment.
I agree with you ... even in English I pondered over: top, up, north ...
I'll leave them hard coded for the moment.
|
I'd also look into just doing all the ray stuff in chessops. This is right up its alley. |
what is the difference between chessground and chessops ? (meaning: why are there 2 repositories and how do you decide to update one or the other ?) |
|
chessops is pure chess rules and logic. Chessground is the package we use to display a chessboard, pieces and anything GUI related to the chessboard. It contains no logic. Relating to NVUI we use chessground instead of chessops because the legal moves (dests) are calculated and sent by the server so we can skip the logic bit and just use the dests that chessground also uses for legal moves. Although blind players do not see the same board we still "use" the same one for legal moves. I said use chessops because it has a lot of helper and utility functions related to chess logic. It also uses bitboards under the hood so you can make use of them and all of the other ray functions that chessops uses to calculate the rays that you need. |
|
I don't think we need chess logic here as it is just about announcing pieces on squares. |
|
What is the status of translation of the nvui? I am working towards trying to make "Learn from your mistakes" usable from the nvui. There are numerous NoTrans(str) calls in analysis.nvui.ts. I know nothing about the translation effort, but want to look towards the future of the nvui. |
fixes #17688 (with a new shortcut x)
related to #17722 (with a new shortcut alt x)
Considering the active square is the origin of the rays:
Example with following position from a black point of view:
x
d1: bottomRight: c2 white pawn
x
d1: bottomLeft: f3 white knight
x
d1: bottomRight: c2 white pawn
alt x
d1: bottom: d2 white pawn , d7 black pawn , d8 black queen
alt x
d1: left: e1 white king , f1 white bishop , h1 white rook
alt x
d1: right: c1 white bishop , b1 white knight , a1 white rook
Note that: