-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
NVUI Retro: Made learn from your mistakes accessible from NVUI #17739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
schlawg
merged 15 commits into
lichess-org:master
from
nicvagn:NVUI-learn-from-your-mistakes
Jun 29, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d2f2e64
NVUI Retro: Made learn from your mistakes accessible from NVUI
nicvagn bfe95b4
Merge branch 'master' of https://github.com/lichess-org/lila into NVU…
nicvagn a463a76
revert using heading in place of labels.
nicvagn 3bc5e6c
notifies about analysis in progress, used centralized css, and rm sup…
nicvagn 4e96a24
ops
nicvagn 7c2d467
Merge branch 'master' of https://github.com/lichess-org/lila into NVU…
nicvagn a85beca
adjusted aria further, cleaned up a bit
nicvagn fbad115
removed redundant tabindexs
nicvagn d34a033
Merge branch 'master' into NVUI-learn-from-your-mistakes
nicvagn 2a3d14f
fix state transitions and redraw loops
schlawg 1690b1b
remove unused variable
schlawg 819a033
Update ui/lib/src/ceval/view/settings.ts
schlawg 6936479
Update ui/analyse/src/retrospect/nvuiRetroView.ts
schlawg 8dd7796
Update ui/analyse/src/retrospect/nvuiRetroView.ts
schlawg 1f4a088
prettier
schlawg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import type AnalyseCtrl from './ctrl'; | ||
| import type { NvuiPlugin } from './interfaces'; | ||
| import * as nvui from 'lib/nvui/chess'; | ||
| import type * as studyDeps from './study/studyDeps'; | ||
| import { renderNvui, initNvui } from './view/nvuiView'; | ||
| import { Notify } from 'lib/nvui/notify'; | ||
| import { type Prop, prop } from 'lib'; | ||
|
|
||
| export type NvuiContext = Readonly<{ | ||
| ctrl: AnalyseCtrl; | ||
| deps?: typeof studyDeps; | ||
| analysisInProgress: Prop<boolean>; | ||
| notify: Notify; | ||
| moveStyle: ReturnType<typeof nvui.styleSetting>; | ||
| pieceStyle: ReturnType<typeof nvui.pieceSetting>; | ||
| prefixStyle: ReturnType<typeof nvui.prefixSetting>; | ||
| positionStyle: ReturnType<typeof nvui.positionSetting>; | ||
| boardStyle: ReturnType<typeof nvui.boardSetting>; | ||
| }>; | ||
|
|
||
| export function initModule(ctrl: AnalyseCtrl): NvuiPlugin { | ||
| const ctx: NvuiContext = { | ||
| ctrl, | ||
| notify: new Notify(), | ||
| analysisInProgress: prop(false), | ||
| moveStyle: nvui.styleSetting(), | ||
| pieceStyle: nvui.pieceSetting(), | ||
| prefixStyle: nvui.prefixSetting(), | ||
| positionStyle: nvui.positionSetting(), | ||
| boardStyle: nvui.boardSetting(), | ||
| }; | ||
| initNvui(ctx); | ||
| return { render: deps => renderNvui({ ...ctx, deps }) }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.