Conversation
…pe == ROTATION_TYPE_TWO_AXIS_VALUATOR_FIXED_UP
…p-axis from working correctly. Fixed up code formatting to better match existing libigl code.
villains
force-pushed
the
rotation_axis_up
branch
from
February 25, 2026 13:14
29b5bf3 to
e048bab
Compare
Contributor
|
Seems fine to me. If CI passes, will merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows you to set the direction of the up axis when
ViewerCore::rotation_typeis set toROTATION_TYPE_TWO_AXIS_VALUATOR_FIXED_UP. By default, the y-axis (0,1,0) is used as the up axis. However there are cases where it is more natural to work with the z-axis as the up axis. For example, when working with geoscientific data, the general convention is that x and y are the geographic coordinates, and z is the elevation. When viewing 3D datasets of this type, the most natural tendency is to rotate about the z-axis.This PR implements the ability to choose the up axis when required.
Together with
ViewerCore::camera_eyeandViewerCore::camera_upthe initial 3D view can be configured to fit more naturally with geoscientific data.Thank you for creating an excellent and easy to use (and integrate) 3D mesh library!
Checklist