Skip to content

tests/AABB: de-flake dynamic-vs-brute-force timing assertion #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecjacobson merged 2 commits into from
Sep 1, 2026
+9 −3
Merged

tests/AABB: de-flake dynamic-vs-brute-force timing assertion #2560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28bbc68
tests/AABB: de-flake dynamic-vs-brute-force timing assertion
Sep 1, 2026
41abbe0
Merge branch 'main' into horde/deflake-aabb-timing
alecjacobson Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/include/igl/AABB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,15 @@ TEST_CASE("AABB: dynamic", "[igl]")
REQUIRE(min_i == qi);
}

// Only compare speeds on large meshes
if(F.rows() > 300)
{
// Only compare speeds on large meshes. Each timing above is a single-point
// query averaged over MAX_RUNS runs — only a few microseconds — so on small
// and medium meshes the tree's O(log n) advantage over the O(n) brute force
// is within timing noise (they are effectively a wash at ~1e3 faces), which
// made this assertion flaky on shared CI runners. Restrict the comparison to
// meshes large enough (here bunny ~69k and elephant ~157k faces) that the
// asymptotic advantage robustly dominates measurement noise.
if(F.rows() > 10000)
{
REQUIRE(t_dynamic_tree < t_static_tree);
REQUIRE(t_dynamic_tree < t_brute_force);
}
Expand Down
Loading