Skip to content

fix(memory): surface SQLite row errors - #6951

Merged
houko merged 2 commits into
mainfrom
fix/memory-row-errors
Aug 12, 2026
Merged

houko merged 2 commits into
mainfrom
fix/memory-row-errors

Conversation

@houko

@houko houko commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • propagate per-row SQLite decode failures from user spend rankings instead of silently omitting users
  • fail memory consolidation when agent IDs or candidate rows cannot be decoded
  • add a regression test proving a malformed ranking row surfaces as an error

Testing

  • cargo test -p librefang-memory test_user_ranking_surfaces_row_decode_errors --lib
  • cargo test -p librefang-memory test_user_ranking_excludes_anonymous_and_orders_by_daily --lib
  • cargo clippy -p librefang-memory --lib -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

@github-actions github-actions Bot added the size/S 10-49 lines changed label Aug 12, 2026
@houko
houko merged commit b4c5ff0 into main Aug 12, 2026
35 checks passed
@houko
houko deleted the fix/memory-row-errors branch August 12, 2026 10:38
houko pushed a commit that referenced this pull request Aug 12, 2026
PR #7033 changes RosterStore's public error contract (upsert, members,
remove_member, member_count now return LibreFangResult) without a
changelog.d fragment, unlike the identical-pattern sibling PR #6951.
Add the fragment so the behavior change reaches the release notes.
houko added a commit that referenced this pull request Aug 13, 2026
* fix: propagate roster storage errors

* docs: add changelog fragment for roster storage error propagation

PR #7033 changes RosterStore's public error contract (upsert, members,
remove_member, member_count now return LibreFangResult) without a
changelog.d fragment, unlike the identical-pattern sibling PR #6951.
Add the fragment so the behavior change reaches the release notes.

---------

Co-authored-by: Evan <tonymo2048@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S 10-49 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants