Skip to content

fix(i18n): restore Spanish error-message diacritics #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
houko merged 2 commits into from
Aug 13, 2026
Merged

fix(i18n): restore Spanish error-message diacritics #6999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
581e1f3
fix(i18n): restore Spanish diacritics
Aug 12, 2026
9994981
docs(changelog): add fragment for Spanish diacritics fix
claude Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/fixed/6999-spanish-error-diacritics.md
View file
Open in desktop

@houko houko Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 9994981 ("docs(changelog): add fragment for Spanish diacritics fix") has an author identity of Claude <noreply@anthropic.com>.
The commit message text itself is clean, but CLAUDE.md's commit-msg hook separately rejects the author identity (git var GIT_AUTHOR_IDENT) when it resolves to Claude/Anthropic, independent of message content.
This will fail local commit-msg verification for anyone who has run just setup / cargo xtask setup, and violates the repo's no-AI-attribution policy even though the hook may not have been active for this push.
Recommend the author amend this commit's author (and committer) identity to their own before merge, e.g. git commit --amend --author="Name <email>" (and force-push their own branch, which is fine pre-review per CLAUDE.md).
The other commit on this branch (581e1f3, "fix(i18n): restore Spanish diacritics") is correctly attributed to Evan <tonymo2048@gmail.com>.

Generated by Claude Code

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Restored missing diacritics and inverted punctuation across the Spanish error-message locale (`válido`, `sesión`, `configuración`, `¿agente no encontrado?`, and similar), and corrected a few literal, unnatural phrasings alongside unit formatting for size limits.
Added regression assertions for representative accented translations so a future edit cannot silently strip them again (#6999) (@houko)
46 changes: 23 additions & 23 deletions crates/librefang-types/locales/es/errors.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,72 +3,72 @@
# Agent errors
api-error-agent-not-found = Agente no encontrado
api-error-agent-spawn-failed = Error al crear el agente
api-error-agent-invalid-id = ID de agente no valido
api-error-session-invalid-id = ID de sesion no valido
api-error-context-report-failed = Informe de contexto fallido
api-error-agent-invalid-id = ID de agente no válido
api-error-session-invalid-id = ID de sesión no válido
api-error-context-report-failed = No se pudo generar el informe de contexto
api-error-agent-already-exists = El agente ya existe

# Message errors
api-error-message-too-large = Mensaje demasiado grande (max 64KB)
api-error-message-too-large = Mensaje demasiado grande (máx. 64 KB)
api-error-message-delivery-failed = Error al enviar el mensaje: { $reason }

# Template errors
api-error-template-invalid-name = Nombre de plantilla no valido
api-error-template-invalid-name = Nombre de plantilla no válido
api-error-template-not-found = Plantilla '{ $name }' no encontrada
api-error-template-parse-failed = Error al analizar la plantilla: { $error }
api-error-template-required = Se requiere 'manifest_toml' o 'template'

# Manifest errors
api-error-manifest-too-large = Manifiesto demasiado grande (max 1MB)
api-error-manifest-invalid-format = Formato de manifiesto no valido
api-error-manifest-too-large = Manifiesto demasiado grande (máx. 1 MB)
api-error-manifest-invalid-format = Formato de manifiesto no válido
api-error-manifest-signature-mismatch = El contenido del manifiesto firmado no coincide con manifest_toml
api-error-manifest-signature-failed = Verificacion de firma del manifiesto fallida
api-error-manifest-signature-failed = Falló la verificación de la firma del manifiesto

# Auth errors
api-error-auth-invalid-key = Clave API no valida
api-error-auth-invalid-key = Clave API no válida
api-error-auth-missing-header = Falta el encabezado Authorization: Bearer <api_key>
api-error-auth-missing = La clave API de este proveedor no esta configurada
api-error-auth-missing = La clave API de este proveedor no está configurada

# Session errors
api-error-session-load-failed = Error al cargar la sesion
api-error-session-not-found = Sesion no encontrada
api-error-session-load-failed = Error al cargar la sesión
api-error-session-not-found = Sesión no encontrada

# Workflow errors
api-error-workflow-missing-steps = Falta el arreglo 'steps'
api-error-workflow-step-needs-agent = El paso '{ $step }' necesita 'agent_id' o 'agent_name'
api-error-workflow-invalid-id = ID de flujo de trabajo no valido
api-error-workflow-execution-failed = Error en la ejecucion del flujo de trabajo
api-error-workflow-invalid-id = ID de flujo de trabajo no válido
api-error-workflow-execution-failed = Error en la ejecución del flujo de trabajo

# Trigger errors
api-error-trigger-missing-agent-id = Falta 'agent_id'
api-error-trigger-invalid-agent-id = agent_id no valido
api-error-trigger-invalid-pattern = Patron de activador no valido
api-error-trigger-invalid-agent-id = agent_id no válido
api-error-trigger-invalid-pattern = Patrón de activador no válido
api-error-trigger-missing-pattern = Falta 'pattern'
api-error-trigger-registration-failed = Error al registrar el activador (agente no encontrado?)
api-error-trigger-invalid-id = ID de activador no valido
api-error-trigger-registration-failed = Error al registrar el activador (¿agente no encontrado?)
api-error-trigger-invalid-id = ID de activador no válido
api-error-trigger-not-found = Activador no encontrado

# Budget errors
api-error-budget-invalid-amount = Monto de presupuesto no valido
api-error-budget-invalid-amount = Monto de presupuesto no válido
api-error-budget-update-failed = Error al actualizar el presupuesto

# Config errors
api-error-config-parse-failed = Error al analizar la configuracion: { $error }
api-error-config-write-failed = Error al escribir la configuracion: { $error }
api-error-config-parse-failed = Error al analizar la configuración: { $error }
api-error-config-write-failed = Error al escribir la configuración: { $error }

# Profile errors
api-error-profile-not-found = Perfil '{ $name }' no encontrado

# Cron errors
api-error-cron-invalid-id = ID de tarea programada no valido
api-error-cron-invalid-id = ID de tarea programada no válido
api-error-cron-not-found = Tarea programada no encontrada
api-error-cron-create-failed = Error al crear la tarea programada: { $error }

# General errors
api-error-not-found = Recurso no encontrado
api-error-internal = Error interno del servidor
api-error-bad-request = Solicitud incorrecta: { $reason }
api-error-rate-limited = Limite de solicitudes excedido. Intente de nuevo mas tarde.
api-error-rate-limited = Límite de solicitudes excedido. Inténtelo de nuevo más tarde.

# Generic catch-all — interpolates the underlying error string verbatim.
# Used by 41+ HTTP 500 handlers as a stopgap until each route is moved to a
Expand Down
6 changes: 6 additions & 0 deletions crates/librefang-types/src/i18n.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,12 @@ mod tests {
fn spanish_translation() {
let t = ErrorTranslator::new("es");
assert_eq!(t.t("api-error-agent-not-found"), "Agente no encontrado");
assert_eq!(t.t("api-error-agent-invalid-id"), "ID de agente no válido");
assert_eq!(t.t("api-error-session-not-found"), "Sesión no encontrada");
assert_eq!(
t.t("api-error-rate-limited"),
"Límite de solicitudes excedido. Inténtelo de nuevo más tarde."
);
}

@houko houko Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanish_translation asserts only 4 of the ~24 keys touched in errors.ftl (agent-invalid-id, session-not-found, rate-limited, plus the pre-existing agent-not-found). The corrected strings with the biggest wording changes — api-error-context-report-failed (fully reworded, not just re-accented) and api-error-manifest-signature-failed (also reworded) — have no assertion, so a future accidental revert of either wouldn't be caught here.

Not a blocker per CLAUDE.md (no hard rule mandates one assertion per Fluent key), but per the "MANDATORY … missing test coverage" review criterion this repo applies to corrected strings, worth a maintainer call on whether to round out coverage before merge or accept the sampled set as sufficient. Leaving this for human judgment rather than unilaterally expanding someone else's test to ~24 asserts.

Generated by Claude Code


#[test]
Expand Down