Repository navigation
fix(memory): preserve goal run start metadata - #7153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
started_atvalue across ordinary state upsertsstarted_atin one atomic SQLite upsertVerification
CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Volumes/Lexar/worktrees/target-7153 cargo test -p librefang-memory goal_run_store --lib— 13 passedCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Volumes/Lexar/worktrees/target-7153 cargo test -p librefang-kernel start_replaces_terminal_row_with_a_fresh_started_at --lib— 1 passedcargo fmt --all -- --checkgit diff --check origin/main...HEADOut of scope
GoalRunRowfield types across crates