Skip to content

fix(acp): preserve filesystem unavailability - #7424

Merged
houko merged 4 commits into
mainfrom
fix/acp-fs-unavailable-errors
Aug 15, 2026
Merged

houko merged 4 commits into
mainfrom
fix/acp-fs-unavailable-errors

Conversation

@houko

@houko houko commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • classify ACP filesystem reverse-RPC timeouts and dropped response channels as KernelOpError::Unavailable
  • make runtime file_read and file_write fall back to the local filesystem only for that unavailable class
  • preserve hard failures for protocol and internal ACP errors
  • add dispatch-level regressions for local read fallback, local write fallback, and non-fallback errors

Inventory finding: F-78fb8e62d385a9e7

Verification

  • CARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo test -p librefang-acp
  • CARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo test -p librefang-runtime acp_unavailable_file -- --nocapture
  • CARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo test -p librefang-runtime acp_internal_file_errors_do_not_fall_back_to_local_filesystem -- --nocapture
  • CARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo clippy -p librefang-acp -p librefang-runtime --all-targets -- -D warnings
  • CARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo check --workspace --lib
  • cargo fmt --all -- --check
  • git diff --check origin/main...HEAD
  • pre-commit and pre-push hooks

Out of scope

  • changing ACP terminal reverse-RPC fallback behavior
  • treating editor-returned protocol errors as local fallback conditions

@github-actions github-actions Bot added the size/S 10-49 lines changed label Aug 15, 2026
@houko
houko enabled auto-merge (squash) August 15, 2026 05:15
@github-actions github-actions Bot added area/runtime Agent loop, LLM drivers, WASM sandbox size/L 250-999 lines changed and removed size/S 10-49 lines changed labels Aug 15, 2026
@houko
houko merged commit 849e68f into main Aug 15, 2026
37 checks passed
@houko
houko deleted the fix/acp-fs-unavailable-errors branch August 15, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/runtime Agent loop, LLM drivers, WASM sandbox size/L 250-999 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant