Repository navigation
fix(acp): preserve filesystem unavailability - #7424
Merged
Merged
Conversation
houko
enabled auto-merge (squash)
August 15, 2026 05:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KernelOpError::Unavailablefile_readandfile_writefall back to the local filesystem only for that unavailable classInventory finding:
F-78fb8e62d385a9e7Verification
CARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo test -p librefang-acpCARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo test -p librefang-runtime acp_unavailable_file -- --nocaptureCARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo test -p librefang-runtime acp_internal_file_errors_do_not_fall_back_to_local_filesystem -- --nocaptureCARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo clippy -p librefang-acp -p librefang-runtime --all-targets -- -D warningsCARGO_TARGET_DIR=/private/tmp/librefang-target-pr7424-final cargo check --workspace --libcargo fmt --all -- --checkgit diff --check origin/main...HEADOut of scope