Skip to content

fix(dashboard): bound sparkline extrema scan #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
houko merged 4 commits into from
Aug 17, 2026
Merged

fix(dashboard): bound sparkline extrema scan #7426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04609a5
fix(dashboard): bound sparkline extrema scan
houko Aug 15, 2026
bb7506b
docs: attribute sparkline bounds changelog
houko Aug 15, 2026
4cefb16
Merge remote-tracking branch 'origin/main' into audit/pr-7426-clean
houko Aug 17, 2026
b670efd
Merge remote-tracking branch 'origin/main' into audit/pr-7426-clean
houko Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed/7426-dashboard-sparkline-bounds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed dashboard sparklines failing to render large data sets that exceed the JavaScript function argument limit. (#7426) (@houko)
6 changes: 6 additions & 0 deletions crates/librefang-api/dashboard/src/components/ui/Sparkline.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,10 @@ describe("Sparkline", () => {

expect(container.querySelector("svg")).toBeNull();
});

it("renders data sets larger than the JavaScript argument limit", () => {
const data = Array.from({ length: 150_000 }, (_, index) => index % 100);

expect(() => render(<Sparkline data={data} />)).not.toThrow();
});
});
8 changes: 6 additions & 2 deletions crates/librefang-api/dashboard/src/components/ui/Sparkline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ export function Sparkline({
}: SparklineProps) {
const uid = useId().replace(/[^a-zA-Z0-9]/g, "");
if (!data || data.length < 2) return null;
const max = Math.max(...data);
const min = Math.min(...data);
let min = data[0];
let max = data[0];
for (let i = 1; i < data.length; i += 1) {
min = Math.min(min, data[i]);
max = Math.max(max, data[i]);
}
const range = max - min || 1;
const stepX = width / (data.length - 1);
const pts = data.map((v, i) => {
Expand Down