Skip to content

fix(dashboard): label skill output controls - #7435

Merged
houko merged 4 commits into
mainfrom
fix/dashboard-skill-output-accessibility
Aug 17, 2026
Merged

houko merged 4 commits into
mainfrom
fix/dashboard-skill-output-accessibility

Conversation

@houko

@houko houko commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Changes

  • expose the skill-output collapse state with aria-expanded and aria-controls
  • give the clear action a reliable translated accessible name
  • name each dismiss action with its skill
  • cover collapse, clear, and per-output dismiss behavior

Inventory findings: F-110fdf3a4f4c0aa8, F-fe80d60ec26cc343, F-b5872c206ace18fc

Verification

  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard exec vitest run src/components/ui/SkillOutputPanel.test.tsx --reporter=dot (3 passed)
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard typecheck
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard lint
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard test -- --reporter=dot (102 files, 1078 tests passed)
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard build
  • git diff --check

Out of scope

  • skill-output store behavior and retention limits
  • panel placement, styling, and responsive layout
  • broader dashboard icon semantics

@github-actions github-actions Bot added no-rust-required This task does not require Rust knowledge size/M 50-249 lines changed labels Aug 15, 2026
@houko
houko enabled auto-merge (squash) August 17, 2026 09:25
@houko
houko merged commit aecd2cd into main Aug 17, 2026
37 checks passed
@houko
houko deleted the fix/dashboard-skill-output-accessibility branch August 17, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-rust-required This task does not require Rust knowledge size/M 50-249 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant