Skip to content

fix(dashboard): preserve input error focus - #7430

Merged
houko merged 4 commits into
mainfrom
fix/dashboard-input-error-focus
Aug 17, 2026
Merged

houko merged 4 commits into
mainfrom
fix/dashboard-input-error-focus

Conversation

@houko

@houko houko commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep red error border, focus ring, and hover border while an invalid dashboard input is active
  • apply brand focus and hover colors only to inputs without an error
  • add focused class-contract regressions for both states

Inventory finding: F-2c327f7cf9ff7043

Verification

  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard exec vitest run src/components/ui/Input.test.tsx (2 passed)
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard test (102 files, 1077 tests passed)
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard typecheck
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard lint
  • corepack pnpm@10.33.0 --dir crates/librefang-api/dashboard build
  • git diff --check
  • pre-commit and pre-push hooks

Out of scope

  • changing input validation rules or error copy
  • changing other form-control components
  • broader design-system color changes

@github-actions github-actions Bot added size/S 10-49 lines changed no-rust-required This task does not require Rust knowledge labels Aug 15, 2026
@houko
houko enabled auto-merge (squash) August 17, 2026 09:24
@houko
houko merged commit 74c65fb into main Aug 17, 2026
37 checks passed
@houko
houko deleted the fix/dashboard-input-error-focus branch August 17, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-rust-required This task does not require Rust knowledge size/S 10-49 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant