Skip to content

fix(extensions): preserve missing error status - #7516

Merged
houko merged 2 commits into
mainfrom
fix/extensions-missing-error-mapping
Aug 15, 2026
Merged

houko merged 2 commits into
mainfrom
fix/extensions-missing-error-mapping

Conversation

@houko

@houko houko commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • preserve NotFound, NotInstalled, and CredentialNotFound as distinct shared integration errors
  • map all three missing-resource variants to HTTP 404 without changing their operator-facing text
  • add shared-type, bridge, and API-status regression coverage
  • add the required changelog fragment

Audit finding: F-5ed431ba4f828858.

Verification

  • mise exec -- cargo test -p librefang-types --lib integration::tests -- --nocapture
  • mise exec -- cargo test -p librefang-extensions --lib extension_error_maps_to_integration_error -- --nocapture
  • mise exec -- cargo test -p librefang-api --lib missing_extension_resources_return_not_found -- --nocapture
  • mise exec -- cargo clippy -p librefang-types -p librefang-extensions -p librefang-api --lib -- -D warnings
  • mise exec -- cargo fmt --check
  • git diff --check
  • python3 scripts/check-changelog-attribution.py --base origin/main --head HEAD

Out of scope

  • vault, installation-conflict, and generic failure mappings are unchanged
  • API response-body scrubbing for internal errors is unchanged

@github-actions github-actions Bot added area/security Security systems and auditing size/S 10-49 lines changed labels Aug 15, 2026
@houko
houko enabled auto-merge (squash) August 15, 2026 15:42
@github-actions github-actions Bot added size/M 50-249 lines changed and removed size/S 10-49 lines changed labels Aug 15, 2026
@houko
houko merged commit 7d5992f into main Aug 15, 2026
39 checks passed
@houko
houko deleted the fix/extensions-missing-error-mapping branch August 15, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Security systems and auditing size/M 50-249 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant