Repository navigation
fix(extensions): preserve missing error status - #7516
Merged
Merged
Conversation
houko
enabled auto-merge (squash)
August 15, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NotFound,NotInstalled, andCredentialNotFoundas distinct shared integration errorsAudit finding:
F-5ed431ba4f828858.Verification
mise exec -- cargo test -p librefang-types --lib integration::tests -- --nocapturemise exec -- cargo test -p librefang-extensions --lib extension_error_maps_to_integration_error -- --nocapturemise exec -- cargo test -p librefang-api --lib missing_extension_resources_return_not_found -- --nocapturemise exec -- cargo clippy -p librefang-types -p librefang-extensions -p librefang-api --lib -- -D warningsmise exec -- cargo fmt --checkgit diff --checkpython3 scripts/check-changelog-attribution.py --base origin/main --head HEADOut of scope